Replace KaFirStopWorldCacheCleaner with no-op implementation #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure how testable this change is, but happy to add a test if someone can point me in the right direction. |
b2a20cf to
172109d
Compare
hfmehmed
approved these changes
Oct 6, 2025
|
LGTM. @ting-yuan can you review too |
|
Thanks jsjeon! When I changed the LoadingState so that the correct registry value would be picked up it caused some other failures which I wasn't familiar with the internals of enough to confidently fix. Happy to work with someone more familiar with the codebase to get that version working if it's preferable. |
ting-yuan
approved these changes
Oct 6, 2025
|
Both of the ways work. Let's merge this for 2.0.4 and revisit it later if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace KaFirStopWorldCacheCleaner with no-op implementation
This cache cleaner leads to flakey build failures in AndroidX. KSP has already updated to a Kotlin AA version which no longer registered the cache cleaner by default for standalone but it is still registered for all other usages. This CL replaces it with a no-op implementation.