-
Notifications
You must be signed in to change notification settings - Fork 108
Adds velocity-based checks to go into skimming mode instead of basing it off of the distance scrolled in a given scroll event. #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.../java/com/google/android/horologist/compose/layout/m3/FastScrollingTransformingLazyColumn.kt
Outdated
Show resolved
Hide resolved
.../java/com/google/android/horologist/compose/layout/m3/FastScrollingTransformingLazyColumn.kt
Outdated
Show resolved
Hide resolved
… into velocitySkim
… into velocitySkim
… into velocitySkim
Ah, finally figured out the problem. The reason why sacreenshot tests keep failing between either header "O" or "R" is because this uses a new timeout based system every 750 ms or so: Two scrolls that happen to start in between might be perceived as a lesser swipe to conserve future scrolls for the velocity. Will be looking to see if I can add a system timer to start actions when the time % 750 == 0 to ensure every screenshot test starts at the same time. |
WHAT
WHY
HOW
Checklist 📋