Skip to content

refactor!: Adjust function names and field types for billing API #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 8, 2025
Merged

refactor!: Adjust function names and field types for billing API #3770

merged 4 commits into from
Oct 8, 2025
+296 −393

Conversation

@zyfy29
Copy link
Contributor

@zyfy29 zyfy29 commented Oct 7, 2025

BREAKING CHANGE: Billing-related methods are renamed to <verb><scope><subject> pattern, and required fields are changed to value types

@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). labels Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.37%. Comparing base (da0feca) to head (7bdb54f).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3770   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         187      187           
  Lines       16760    16760           
=======================================
  Hits        15315    15315           
  Misses       1257     1257           
  Partials      188      188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 7, 2025

@zyfy29 - I'm not seeing any renamed methods in this PR. In fact, the description doesn't appear to match the PR. Can you please clarify?

zyfy29
zyfy29 commented Oct 8, 2025
View reviewed changes
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 8, 2025

Sorry, @zyfy29 - GitHub UI was completely freaking out on me... it showed no changes whatsoever to any methods.
Now it is showing them. I don't know what happened.

gmlewis
gmlewis approved these changes Oct 8, 2025
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zyfy29!
LGTM.
Awaiting second LGTM+Approval from any other contributor before merging.

cc: @stevehipwell - @alexandear

alexandear
alexandear suggested changes Oct 8, 2025
View reviewed changes
@zyfy29 zyfy29 requested a review from alexandear October 8, 2025 14:32
stevehipwell
stevehipwell approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI the GitHub UI is all over the place, I suspect it's rendering for non-latest commits. A page refresh has generally fixed this.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 8, 2025
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 8, 2025

Thank you, @alexandear and @stevehipwell!
Merging.

@gmlewis gmlewis merged commit 06b8b3a into google:master Oct 8, 2025
8 checks passed
@gmlewis gmlewis mentioned this pull request Oct 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

+2 more reviewers

@alexandear alexandear alexandear approved these changes

@stevehipwell stevehipwell stevehipwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zyfy29 @gmlewis @alexandear @stevehipwell