Skip to content

refactor: Simplify for range loops #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 1 commit into from
Oct 6, 2025
Merged

refactor: Simplify for range loops #3762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor: Simplify for range loops
  • Loading branch information
@alexandear
alexandear committed Oct 6, 2025
commit 170d23713ace4f2d9554500c713ecf9783fde60f
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ linters:
- godot
- goheader
- gosec
- intrange
- misspell
- nakedret
- paralleltest
Expand Down
2 changes: 1 addition & 1 deletion github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ func testAddURLOptions(t *testing.T, url string, v any, want string) {
t.Helper()

vt := reflect.Indirect(reflect.ValueOf(v)).Type()
for i := 0; i < vt.NumField(); i++ {
for i := range vt.NumField() {
field := vt.Field(i)
if alias, ok := field.Tag.Lookup("url"); ok {
if alias == "" {
Expand Down
4 changes: 2 additions & 2 deletions github/strings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func stringifyValue(w *bytes.Buffer, val reflect.Value) {
fmt.Fprintf(w, `"%v"`, v)
case reflect.Slice:
w.WriteByte('[')
for i := 0; i < v.Len(); i++ {
for i := range v.Len() {
if i > 0 {
w.WriteByte(' ')
}
Expand All @@ -62,7 +62,7 @@ func stringifyValue(w *bytes.Buffer, val reflect.Value) {
w.WriteByte('{')

var sep bool
for i := 0; i < v.NumField(); i++ {
for i := range v.NumField() {
fv := v.Field(i)
if fv.Kind() == reflect.Pointer && fv.IsNil() {
continue
Expand Down
Loading