Skip to content

fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration #3707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

fix!: Return RepositoryAttachment from GetRepositoriesForCodeSecurityConfiguration #3707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae0b362
fix #3217 unmarshal error
ericmort Aug 30, 2025
95f53e6
Merge branch 'master' into fix-json-unmarshal-error
ericmort Sep 23, 2025
b37c805
fixed linter and test issues
ericmort Sep 23, 2025
ecee97a
Merge branch 'fix-json-unmarshal-error' of https://github.com/ericmor…
ericmort Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 11 additions & 4 deletions github/orgs_codesecurity_configurations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ type DependencyGraphAutosubmitActionOptions struct {
LabeledRunners *bool `json:"labeled_runners,omitempty"`
}

// RepositoryAttachment represents a repository attachment to a code security configuration.
type RepositoryAttachment struct {
Status *string `json:"status"`
Repository *Repository `json:"repository"`
}

// CodeSecurityConfiguration represents a code security configuration.
type CodeSecurityConfiguration struct {
ID *int64 `json:"id,omitempty"`
Expand Down Expand Up @@ -247,20 +253,21 @@ func (s *OrganizationsService) SetDefaultCodeSecurityConfiguration(ctx context.C
// GitHub API docs: https://docs.github.com/rest/code-security/configurations#get-repositories-associated-with-a-code-security-configuration
//
//meta:operation GET /orgs/{org}/code-security/configurations/{configuration_id}/repositories
func (s *OrganizationsService) GetRepositoriesForCodeSecurityConfiguration(ctx context.Context, org string, id int64) ([]*Repository, *Response, error) {
func (s *OrganizationsService) GetRepositoriesForCodeSecurityConfiguration(ctx context.Context, org string, id int64) ([]*RepositoryAttachment, *Response, error) {
u := fmt.Sprintf("orgs/%v/code-security/configurations/%v/repositories", org, id)

req, err := s.client.NewRequest("GET", u, nil)
if err != nil {
return nil, nil, err
}

var repositories []*Repository
resp, err := s.client.Do(ctx, req, &repositories)
var attachments []*RepositoryAttachment
resp, err := s.client.Do(ctx, req, &attachments)
if err != nil {
return nil, resp, err
}
return repositories, resp, nil

return attachments, resp, nil
}

// GetCodeSecurityConfigurationForRepository gets code security configuration that manages a repository's code security settings.
Expand Down
30 changes: 18 additions & 12 deletions github/orgs_codesecurity_configurations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,26 +416,32 @@ func TestOrganizationsService_GetRepositoriesForCodeSecurityConfiguration(t *tes
testMethod(t, r, "GET")
fmt.Fprint(w, `[
{
"id":8,
"name":"repo8"
"status": "attached",
"repository": {
"id":8,
"name":"repo8"
}
},
{
"id":42,
"name":"repo42"
}]`)
"status": "attached",
"repository": {
"id":42,
"name":"repo42"
}
}
]`)
})

repositories, _, err := client.Organizations.GetRepositoriesForCodeSecurityConfiguration(ctx, "o", 1)
attachments, _, err := client.Organizations.GetRepositoriesForCodeSecurityConfiguration(ctx, "o", 1)
if err != nil {
t.Errorf("Organizations.GetRepositoriesForCodeSecurityConfiguration returned error: %v", err)
}

want := []*Repository{
{ID: Ptr(int64(8)), Name: Ptr("repo8")},
{ID: Ptr(int64(42)), Name: Ptr("repo42")},
want := []*RepositoryAttachment{
{Status: Ptr("attached"), Repository: &Repository{ID: Ptr(int64(8)), Name: Ptr("repo8")}},
{Status: Ptr("attached"), Repository: &Repository{ID: Ptr(int64(42)), Name: Ptr("repo42")}},
}
if !cmp.Equal(repositories, want) {
t.Errorf("Organizations.GetRepositoriesForCodeSecurityConfiguration returned %+v, want %+v", repositories, want)
if !cmp.Equal(attachments, want) {
t.Errorf("Organizations.GetRepositoriesForCodeSecurityConfiguration returned %+v, want %+v", attachments, want)
}

const methodName = "GetRepositoriesForCodeSecurityConfiguration"
Expand Down
Loading