change method names

google · gmlewis · Oct 7, 2025 · Aug 18, 2025 · Aug 18, 2025 · Aug 18, 2025
commit 3a24cda807745d650a4ec1d2f31b7e0c382a87a2
diff --git a/github/secret_scanning.go b/github/secret_scanning.go
@@ -120,13 +120,13 @@ type SecretScanningAlertUpdateOptions struct {
 	ResolutionComment *string `json:"resolution_comment,omitempty"`
 }
 
-// CreatePushProtectionBypass represents the parameters for PushProtectionBypasses.
-type CreatePushProtectionBypass struct {
+// CreatePushProtectionBypass represents the parameters for CreatePushProtectionBypass.
+type PushProtectionBypassRequest struct {
 	Reason        string `json:"reason"`
 	PlaceholderID string `json:"placeholder_id"`
 }
 
-// PushProtectionBypass represents the responses from PushProtectionBypasses.
+// PushProtectionBypass represents the responses from CreatePushProtectionBypass.
 type PushProtectionBypass struct {
 	Reason    string     `json:"reason"`
 	ExpireAt  *Timestamp `json:"expire_at"`
@@ -322,15 +322,15 @@ func (s *SecretScanningService) ListLocationsForAlert(ctx context.Context, owner
 	return locations, resp, nil
 }
 
-// PushProtectionBypasses creates a push protection bypass for a given repository.
+// CreatePushProtectionBypass creates a push protection bypass for a given repository.
 //
 // To use this endpoint, you must be an administrator for the repository or organization, and you must use an access token with
 // the repo scope or security_events scope.
 //
 // GitHub API docs: https://docs.github.com/rest/secret-scanning/secret-scanning#create-a-push-protection-bypass
 //
 //meta:operation POST /repos/{owner}/{repo}/secret-scanning/push-protection-bypasses
-func (s *SecretScanningService) PushProtectionBypasses(ctx context.Context, owner, repo string, opts *CreatePushProtectionBypass) (*PushProtectionBypass, *Response, error) {
+func (s *SecretScanningService) CreatePushProtectionBypass(ctx context.Context, owner, repo string, opts *PushProtectionBypassRequest) (*PushProtectionBypass, *Response, error) {
 	u := fmt.Sprintf("repos/%v/%v/secret-scanning/push-protection-bypasses", owner, repo)
 
 	req, err := s.client.NewRequest("POST", u, opts)
@@ -345,15 +345,15 @@ func (s *SecretScanningService) PushProtectionBypasses(ctx context.Context, owne
 	return reponsePushProtectionBypass, resp, nil
 }
 
-// ScanHistory fetches the secret scanning history for a given repository.
+// GetScanHistory fetches the secret scanning history for a given repository.
 //
 // To use this endpoint, you must be an administrator for the repository or organization, and you must use an access token with
 // the repo scope or security_events scope and gitHub advanced security or secret scanning must be enabled.
 //
 // GitHub API docs: https://docs.github.com/rest/secret-scanning/secret-scanning#get-secret-scanning-scan-history-for-a-repository
 //
 //meta:operation GET /repos/{owner}/{repo}/secret-scanning/scan-history
-func (s *SecretScanningService) ScanHistory(ctx context.Context, owner, repo string) (*SecretScanningResponse, *Response, error) {
+func (s *SecretScanningService) GetScanHistory(ctx context.Context, owner, repo string) (*SecretScanningResponse, *Response, error) {
 	u := fmt.Sprintf("repos/%v/%v/secret-scanning/scan-history", owner, repo)
 
 	req, err := s.client.NewRequest("GET", u, nil)

diff --git a/github/secret_scanning_test.go b/github/secret_scanning_test.go
@@ -617,7 +617,7 @@ func TestSecretScanningAlertUpdateOptions_Marshal(t *testing.T) {
 
 	testJSONMarshal(t, u, want)
 }
-func TestSecretScanningService_PushProtectionBypasses(t *testing.T) {
+func TestSecretScanningService_CreatePushProtectionBypass(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)
 
@@ -626,9 +626,9 @@ func TestSecretScanningService_PushProtectionBypasses(t *testing.T) {
 
 	mux.HandleFunc(fmt.Sprintf("/repos/%v/%v/secret-scanning/push-protection-bypasses", owner, repo), func(w http.ResponseWriter, r *http.Request) {
 		testMethod(t, r, "POST")
-		var v *CreatePushProtectionBypass
+		var v *PushProtectionBypassRequest
 		assertNilError(t, json.NewDecoder(r.Body).Decode(&v))
-		want := &CreatePushProtectionBypass{Reason: "valid reason", PlaceholderID: "bypass-123"}
+		want := &PushProtectionBypassRequest{Reason: "valid reason", PlaceholderID: "bypass-123"}
 		if !cmp.Equal(v, want) {
 			t.Errorf("Request body = %+v, want %+v", v, want)
 		}
@@ -641,11 +641,11 @@ func TestSecretScanningService_PushProtectionBypasses(t *testing.T) {
 	})
 
 	ctx := context.Background()
-	opts := &CreatePushProtectionBypass{Reason: "valid reason", PlaceholderID: "bypass-123"}
+	opts := &PushProtectionBypassRequest{Reason: "valid reason", PlaceholderID: "bypass-123"}
 
-	bypass, _, err := client.SecretScanning.PushProtectionBypasses(ctx, owner, repo, opts)
+	bypass, _, err := client.SecretScanning.CreatePushProtectionBypass(ctx, owner, repo, opts)
 	if err != nil {
-		t.Errorf("SecretScanning.PushProtectionBypasses returned error: %v", err)
+		t.Errorf("SecretScanning.CreatePushProtectionBypass returned error: %v", err)
 	}
 
 	expireTime := Timestamp{time.Date(2018, time.January, 1, 0, 0, 0, 0, time.UTC)}
@@ -656,19 +656,19 @@ func TestSecretScanningService_PushProtectionBypasses(t *testing.T) {
 	}
 
 	if !cmp.Equal(bypass, want) {
-		t.Errorf("SecretScanning.PushProtectionBypasses returned %+v, want %+v", bypass, want)
+		t.Errorf("SecretScanning.CreatePushProtectionBypass returned %+v, want %+v", bypass, want)
 	}
-	const methodName = "PushProtectionBypasses"
+	const methodName = "CreatePushProtectionBypass"
 	testBadOptions(t, methodName, func() (err error) {
-		_, _, err = client.SecretScanning.PushProtectionBypasses(ctx, "\n", "\n", opts)
+		_, _, err = client.SecretScanning.CreatePushProtectionBypass(ctx, "\n", "\n", opts)
 		return err
 	})
 	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
-		_, resp, err := client.SecretScanning.PushProtectionBypasses(ctx, "o", "r", opts)
+		_, resp, err := client.SecretScanning.CreatePushProtectionBypass(ctx, "o", "r", opts)
 		return resp, err
 	})
 }
-func TestSecretScanningService_ScanHistory(t *testing.T) {
+func TestSecretScanningService_GetScanHistory(t *testing.T) {
 	t.Parallel()
 	client, mux, _ := setup(t)
 
@@ -703,9 +703,9 @@ func TestSecretScanningService_ScanHistory(t *testing.T) {
 
 	ctx := context.Background()
 
-	history, _, err := client.SecretScanning.ScanHistory(ctx, owner, repo)
+	history, _, err := client.SecretScanning.GetScanHistory(ctx, owner, repo)
 	if err != nil {
-		t.Errorf("SecretScanning.ScanHistory returned error: %v", err)
+		t.Errorf("SecretScanning.GetScanHistory returned error: %v", err)
 	}
 
 	startAt1 := Timestamp{time.Date(2025, time.July, 29, 9, 55, 0, 0, time.UTC)}
@@ -728,15 +728,15 @@ func TestSecretScanningService_ScanHistory(t *testing.T) {
 	}
 
 	if !cmp.Equal(history, want) {
-		t.Errorf("SecretScanning.ScanHistory returned %+v, want %+v", history, want)
+		t.Errorf("SecretScanning.GetScanHistory returned %+v, want %+v", history, want)
 	}
-	const methodName = "ScanHistory"
+	const methodName = "GetScanHistory"
 	testBadOptions(t, methodName, func() (err error) {
-		_, _, err = client.SecretScanning.ScanHistory(ctx, "\n", "\n")
+		_, _, err = client.SecretScanning.GetScanHistory(ctx, "\n", "\n")
 		return err
 	})
 	testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
-		_, resp, err := client.SecretScanning.ScanHistory(ctx, "o", "r")
+		_, resp, err := client.SecretScanning.GetScanHistory(ctx, "o", "r")
 		return resp, err
 	})
 }