Skip to content

Conversation

ihor-hrytskiv
Copy link
Contributor

Suggestion to add support for code_scanning in Github API.

Ruleset API docs

Copy link

google-cla bot commented Sep 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ihor-hrytskiv ihor-hrytskiv force-pushed the feat/code-scanning-rulesets branch from 9c450af to 0dba8da Compare September 3, 2024 14:58
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (2b8c7fa) to head (10a26f4).
Report is 155 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3256      +/-   ##
==========================================
- Coverage   97.72%   93.42%   -4.30%     
==========================================
  Files         153      172      +19     
  Lines       13390    11922    -1468     
==========================================
- Hits        13085    11138    -1947     
- Misses        215      691     +476     
- Partials       90       93       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ihor-hrytskiv!
One minor tweak, please, and also make sure to read step 4 of CONTRIBUTING.md and push (not force-push) the changes to this PR.

Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

@ihor-hrytskiv
Copy link
Contributor Author

Thank you, @ihor-hrytskiv! One minor tweak, please, and also make sure to read step 4 of CONTRIBUTING.md and push (not force-push) the changes to this PR.

Then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Thank you, @gmlewis and sorry for force-push

Signed-off-by: Ihor Hrytskiv <[email protected]>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ihor-hrytskiv !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 3, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 3, 2024

@ihor-hrytskiv - can you please resolve the conflicts in this PR and push (not force-push) the updates when you get a chance? Hopefully we will then get a second LGTM+Approval and can proceed to merge. Thank you!

Copy link
Contributor

@air-hand air-hand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

},
}),
},
"Invalid Required workflows params": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 17, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 17, 2024

Thank you, @air-hand !
Updating branch...

@gmlewis gmlewis merged commit 8c273e1 into google:master Oct 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants