Skip to content

Turn RequiredStatusChecks Checks and Contexts into pointers #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 4 commits into from
Feb 11, 2024
Merged

Turn RequiredStatusChecks Checks and Contexts into pointers #3070

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
953a462
Remove support for Contexts on RequiredStatusChecks
emmahsax Feb 9, 2024
95845c9
Switch to pointers
emmahsax Feb 9, 2024
36606c6
Respace
emmahsax Feb 9, 2024
4741b40
Run script files to ensure linting and tests succeed
emmahsax Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run script files to ensure linting and tests succeed
  • Loading branch information
@emmahsax
emmahsax committed Feb 10, 2024
commit 4741b40ec82d01d9b1165ab7a2b1691778ef840f
16 changes: 16 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 20 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/integration/repos_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func TestRepositories_EditBranches(t *testing.T) {
protectionRequest := &github.ProtectionRequest{
RequiredStatusChecks: &github.RequiredStatusChecks{
Strict: true,
Contexts: []string{"continuous-integration"},
Contexts: &[]string{"continuous-integration"},
},
RequiredPullRequestReviews: &github.PullRequestReviewsEnforcementRequest{
DismissStaleReviews: true,
Expand All @@ -126,7 +126,7 @@ func TestRepositories_EditBranches(t *testing.T) {
want := &github.Protection{
RequiredStatusChecks: &github.RequiredStatusChecks{
Strict: true,
Contexts: []string{"continuous-integration"},
Contexts: &[]string{"continuous-integration"},
},
RequiredPullRequestReviews: &github.PullRequestReviewsEnforcement{
DismissStaleReviews: true,
Expand Down