Skip to content

Remove ambiguous fields from AuditEntry #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 14 commits into from
Dec 18, 2023
Merged

Remove ambiguous fields from AuditEntry #3017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
37375e6
Remove ambiguous fields from AuditEntry
WillAbides Dec 5, 2023
28b5125
remove commented code
WillAbides Dec 5, 2023
a1c4472
apply review suggestions
WillAbides Dec 6, 2023
3e58e36
Fix broken CreateOrUpdateRepoCustomPropertyValues (#3023)
peter-aglen Dec 8, 2023
2332875
Bump actions/setup-go from 4 to 5 (#3027)
dependabot[bot] Dec 11, 2023
0c16a61
Add scanning validity checks (#3026)
tomasz-adam-skrzypczak Dec 14, 2023
bf8d5d5
Add Referrer field to AuditEntry (#3032)
ngoduykhanh Dec 15, 2023
d6af4c8
Add code_search and dependency_snapshots for RateLimits (#3019)
rufusnufus Dec 15, 2023
574f3a7
Support temporary private fork creation via API (#3025)
Kiyo510 Dec 15, 2023
c57201c
Escape package names to support names which include a slash (#3002)
bn4t Dec 16, 2023
2664df0
Don't update httpClient passed to NewClient (#3011)
WillAbides Dec 16, 2023
97776bc
Merge branch 'master' into WillAbides-auditentry
gmlewis Dec 18, 2023
d42e0be
Merge master
gmlewis Dec 18, 2023
3a42286
Add missing fields like referrer
gmlewis Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 19 additions & 24 deletions github/enterprise_audit_log_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import (
"net/http"
"testing"
"time"

"github.com/google/go-cmp/cmp"
)

func TestEnterpriseService_GetAuditLog(t *testing.T) {
Expand Down Expand Up @@ -54,34 +52,31 @@ func TestEnterpriseService_GetAuditLog(t *testing.T) {
if err != nil {
t.Errorf("Enterprise.GetAuditLog returned error: %v", err)
}
startedAt, _ := time.Parse(time.RFC3339, "2021-03-07T00:33:04.000Z")
completedAt, _ := time.Parse(time.RFC3339, "2021-03-07T00:35:08.000Z")
timestamp := time.Unix(0, 1615077308538*1e6)

want := []*AuditEntry{
{
Timestamp: &Timestamp{timestamp},
DocumentID: String("beeZYapIUe-wKg5-beadb33"),
Action: String("workflows.completed_workflow_run"),
Actor: String("testactor"),
CompletedAt: &Timestamp{completedAt},
Conclusion: String("success"),
CreatedAt: &Timestamp{timestamp},
Event: String("schedule"),
HeadBranch: String("master"),
HeadSHA: String("5acdeadbeef64d1a62388e901e5cdc9358644b37"),
Name: String("Code scanning - action"),
Org: String("o"),
Repo: String("o/blue-crayon-1"),
StartedAt: &Timestamp{startedAt},
WorkflowID: Int64(123456),
WorkflowRunID: Int64(628312345),
Timestamp: &Timestamp{timestamp},
DocumentID: String("beeZYapIUe-wKg5-beadb33"),
Action: String("workflows.completed_workflow_run"),
Actor: String("testactor"),
CreatedAt: &Timestamp{timestamp},
Org: String("o"),
AdditionalFields: map[string]interface{}{
"completed_at": "2021-03-07T00:35:08.000Z",
"conclusion": "success",
"event": "schedule",
"head_branch": "master",
"head_sha": "5acdeadbeef64d1a62388e901e5cdc9358644b37",
"name": "Code scanning - action",
"repo": "o/blue-crayon-1",
"started_at": "2021-03-07T00:33:04.000Z",
"workflow_id": float64(123456),
"workflow_run_id": float64(628312345),
},
},
}

if !cmp.Equal(auditEntries, want) {
t.Errorf("Enterprise.GetAuditLog return \ngot: %+v,\nwant:%+v", auditEntries, want)
}
assertNoDiff(t, want, auditEntries)

const methodName = "GetAuditLog"
testBadOptions(t, methodName, func() (err error) {
Expand Down
Loading