Skip to content

Create MarkdownService, EmojisService, CodesOfConductService and MetaService #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 15 commits into from
Oct 9, 2023
Merged

Create MarkdownService, EmojisService, CodesOfConductService and MetaService #2937

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
90a6bb3
Create new services
WillAbides Sep 20, 2023
107ee30
fix ListEmojis
WillAbides Sep 20, 2023
fb26df4
move services to their own files
WillAbides Sep 20, 2023
9306ab4
Revert "move services to their own files"
WillAbides Sep 20, 2023
3aa3e33
godoc
WillAbides Sep 20, 2023
6f4b8a1
call deprecated methods from test to increase coverage
WillAbides Sep 20, 2023
2c0768b
move services to separate files
WillAbides Sep 21, 2023
f10a72e
Update github/meta.go
WillAbides Sep 21, 2023
e3d0031
Merge branch 'master' into nomisc
WillAbides Sep 21, 2023
8442e31
dedup names
WillAbides Sep 21, 2023
c86f81e
rename Markdown to Render
WillAbides Sep 21, 2023
843273d
Rename MetaService.APIMeta to MetaService.Get
WillAbides Sep 21, 2023
cefc779
Apply suggestions from code review
WillAbides Oct 7, 2023
118ec2f
Fix service name
WillAbides Oct 7, 2023
619aee5
Merge branch 'master' into nomisc
WillAbides Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix service name
  • Loading branch information
@WillAbides
WillAbides committed Oct 7, 2023
commit 118ec2ff14ba04b7603a58d460fa8ec5ae5da9e1
12 changes: 6 additions & 6 deletions github/meta_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func TestMetaService_Get(t *testing.T) {
})

ctx := context.Background()
meta, _, err := client.MetaService.Get(ctx)
meta, _, err := client.Meta.Get(ctx)
if err != nil {
t.Errorf("Get returned error: %v", err)
}
Expand All @@ -80,7 +80,7 @@ func TestMetaService_Get(t *testing.T) {

const methodName = "Get"
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.MetaService.Get(ctx)
got, resp, err := client.Meta.Get(ctx)
if got != nil {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
Expand All @@ -103,7 +103,7 @@ func TestMetaService_Octocat(t *testing.T) {
})

ctx := context.Background()
got, _, err := client.MetaService.Octocat(ctx, input)
got, _, err := client.Meta.Octocat(ctx, input)
if err != nil {
t.Errorf("Octocat returned error: %v", err)
}
Expand All @@ -114,7 +114,7 @@ func TestMetaService_Octocat(t *testing.T) {

const methodName = "Octocat"
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.MetaService.Octocat(ctx, input)
got, resp, err := client.Meta.Octocat(ctx, input)
if got != "" {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
Expand All @@ -135,7 +135,7 @@ func TestMetaService_Zen(t *testing.T) {
})

ctx := context.Background()
got, _, err := client.MetaService.Zen(ctx)
got, _, err := client.Meta.Zen(ctx)
if err != nil {
t.Errorf("Zen returned error: %v", err)
}
Expand All @@ -146,7 +146,7 @@ func TestMetaService_Zen(t *testing.T) {

const methodName = "Zen"
testNewRequestAndDoFailure(t, methodName, client, func() (*Response, error) {
got, resp, err := client.MetaService.Zen(ctx)
got, resp, err := client.Meta.Zen(ctx)
if got != "" {
t.Errorf("testNewRequestAndDoFailure %v = %#v, want nil", methodName, got)
}
Expand Down