Skip to content

Add WebhookTypes and EventForType methods #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 9 commits into from
Aug 16, 2023
Merged

Add WebhookTypes and EventForType methods #2865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
575929f
Add WebhookTypes and EventForType methods
evankanderson Aug 10, 2023
98b730e
Switch to a map of types and reflection for names, reduce future code…
evankanderson Aug 10, 2023
2b545ee
Fix Unmarshal(nil) error and add tests for ParsePayload on a zero-val…
evankanderson Aug 10, 2023
76a0c03
Merge remote-tracking branch 'upstream/master'
evankanderson Aug 14, 2023
759f9be
Address gmlewis feedback
evankanderson Aug 14, 2023
2d83b50
Merge #2868 and address gmlewis feedback
evankanderson Aug 15, 2023
ed58239
Use :=, since go figures out the type correctly
evankanderson Aug 15, 2023
96eee83
Merge remote-tracking branch 'upstream/master'
evankanderson Aug 15, 2023
848850a
Update github/messages.go
gmlewis Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Unmarshal(nil) error and add tests for ParsePayload on a zero-val… 
…ue Event{}
  • Loading branch information
@evankanderson
evankanderson committed Aug 10, 2023
commit 2b545ee043cfceef526df2be5ad97add46c2778e
12 changes: 8 additions & 4 deletions github/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,16 @@ func (e Event) String() string {

// ParsePayload parses the event payload. For recognized event types,
// a value of the corresponding struct type will be returned.
func (e *Event) ParsePayload() (interface{}, error) {
func (e *Event) ParsePayload() (payload interface{}, err error) {
// It would be nice if e.Type were the snake_case name of the event,
// but the existing interface uses the struct name instead.
payload := EventForType(typeToMessageMapping[e.GetType()])
err := json.Unmarshal(*e.RawPayload, &payload)
return payload, err
typed := EventForType(typeToMessageMapping[e.GetType()])
if typed != nil {
payload = typed
}
err = json.Unmarshal(e.GetRawPayload(), &payload)

return
}

// Payload returns the parsed event payload. For recognized event types,
Expand Down
5 changes: 5 additions & 0 deletions github/event_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ func TestPayload_NoPanic(t *testing.T) {
e.Payload()
}

func TestEmptyEvent_NoPanic(t *testing.T) {
e := &Event{}
e.ParsePayload()
}

func TestEvent_Marshal(t *testing.T) {
testJSONMarshal(t, &Event{}, "{}")

Expand Down
9 changes: 9 additions & 0 deletions github/messages_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,15 @@ func TestAllMessageTypesMapped(t *testing.T) {
}
}

func TestUnknownMessageType(t *testing.T) {
if obj := EventForType("unknown"); obj != nil {
t.Errorf("EventForType(unknown) = %#v, want nil", obj)
}
if obj := EventForType(""); obj != nil {
t.Errorf(`EventForType("") = %#v, want nil`, obj)
}
}

func TestParseWebHook_BadMessageType(t *testing.T) {
if _, err := ParseWebHook("bogus message type", []byte("{}")); err == nil {
t.Fatal("ParseWebHook returned nil; wanted error")
Expand Down