Skip to content

Add Topics to PushEventRepository #2742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 3 commits into from
Apr 8, 2023
Merged

Add Topics to PushEventRepository #2742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
733c09b
adding topics to push event repo struct
ecrupper Apr 7, 2023
b8dfc96
fix awkward formatting in test payload
ecrupper Apr 8, 2023
2892768
another go at the formatting....
ecrupper Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
adding topics to push event repo struct
  • Loading branch information
@ecrupper
ecrupper committed Apr 7, 2023
commit 733c09b36d0c2c9b0b262b6bf7c5d025aff50455
1 change: 1 addition & 0 deletions github/event_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,6 +1062,7 @@ type PushEventRepository struct {
SSHURL *string `json:"ssh_url,omitempty"`
CloneURL *string `json:"clone_url,omitempty"`
SVNURL *string `json:"svn_url,omitempty"`
Topics []string `json:"topics,omitempty"`
}

// PushEventRepoOwner is a basic representation of user/org in a PushEvent payload.
Expand Down
7 changes: 6 additions & 1 deletion github/event_types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12271,6 +12271,7 @@ func TestPushEventRepository_Marshal(t *testing.T) {
SSHURL: String("s"),
CloneURL: String("c"),
SVNURL: String("s"),
Topics: []string{"octocat", "api"},
}

want := `{
Expand Down Expand Up @@ -12325,7 +12326,11 @@ func TestPushEventRepository_Marshal(t *testing.T) {
"git_url": "g",
"ssh_url": "s",
"clone_url": "c",
"svn_url": "s"
"svn_url": "s",
"topics": [
"octocat",
"api"
]
}`

testJSONMarshal(t, u, want)
Expand Down