Skip to content

Add fields to Branch Protection endpoint #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 3 commits into from
Apr 9, 2023
Merged

Add fields to Branch Protection endpoint #2744

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14b3be5
Add fields to `Branch Protection` endpoint
yardenshoham Apr 8, 2023
386f4bc
Use `SignaturesProtectedBranch` instead of `RequiredSignatures` and `…
yardenshoham Apr 9, 2023
23e1c6e
Move `URL` to the end
yardenshoham Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use SignaturesProtectedBranch instead of RequiredSignatures and `… 
…URL` instead of `Url`
  • Loading branch information
@yardenshoham
yardenshoham committed Apr 9, 2023
commit 386f4bcb2ce113f0cdf9d923c122dbef12387332
26 changes: 13 additions & 13 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 15 additions & 15 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions github/repos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,11 +834,6 @@ type Branch struct {
Protected *bool `json:"protected,omitempty"`
}

type RequiredSignatures struct {
Url string `json:"url"`
Enabled bool `json:"enabled"`
}

// Protection represents a repository branch's protection.
type Protection struct {
RequiredStatusChecks *RequiredStatusChecks `json:"required_status_checks"`
Expand All @@ -852,8 +847,8 @@ type Protection struct {
BlockCreations *BlockCreations `json:"block_creations,omitempty"`
LockBranch *LockBranch `json:"lock_branch,omitempty"`
AllowForkSyncing *AllowForkSyncing `json:"allow_fork_syncing,omitempty"`
RequiredSignatures *RequiredSignatures `json:"required_signatures,omitempty"`
Url *string `json:"url,omitempty"`
RequiredSignatures *SignaturesProtectedBranch `json:"required_signatures,omitempty"`
URL *string `json:"url,omitempty"`
}

// BlockCreations represents whether users can push changes that create branches. If this is true, this
Expand Down Expand Up @@ -1022,8 +1017,8 @@ type ProtectionRequest struct {

// RequiredStatusChecks represents the protection status of a individual branch.
type RequiredStatusChecks struct {
Url *string `json:"url,omitempty"`
ContextsUrl *string `json:"contexts_url,omitempty"`
URL *string `json:"url,omitempty"`
ContextsURL *string `json:"contexts_url,omitempty"`
// Require branches to be up to date before merging. (Required.)
Strict bool `json:"strict"`
// The list of status checks to require in order to merge into this
Expand Down