Skip to content

Add support for the secret scanning API #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 12 commits into from
Feb 4, 2022
Merged

Add support for the secret scanning API #2281

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0bc790a
feat: add support for the secret scanning API
Feb 2, 2022
4bee1a2
feat: generated accessors for secret scanning service
Feb 3, 2022
bbd0984
feat: add secret scanning service to client
Feb 3, 2022
ef2bbb2
fix: make paths relative
Feb 3, 2022
f6172c6
test: add tests for secret scanning service
Feb 3, 2022
0e2b8cf
fix: add missing fields in alert location details
Feb 3, 2022
638bc01
fix: change numbers from int64 to int
Feb 3, 2022
8c33346
fix: change the fields to be pointers
Feb 3, 2022
f335e63
test: fixed type errors
Feb 3, 2022
1fa1c74
fix: removed unnecessary struct
Feb 3, 2022
9bd3972
docs: add missing struct descriptions
Feb 3, 2022
000bc40
fix: generated missing accessors
Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fixed type errors
  • Loading branch information
João Cerqueira committed Feb 3, 2022
commit f335e63233a619453200ee9f875102f16e88a33a
22 changes: 11 additions & 11 deletions github/secret_scanning_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ func TestSecretScanningService_ListAlertsForEnterprise(t *testing.T) {
date := Timestamp{time.Date(1996, time.June, 20, 00, 00, 00, 0, time.UTC)}
want := []*SecretScanningAlert{
{
Number: Int64(1),
Number: Int(1),
CreatedAt: &date,
URL: String("https://api.github.com/repos/o/r/secret-scanning/alerts/1"),
HTMLURL: String("https://github.com/o/r/security/secret-scanning/1"),
Expand Down Expand Up @@ -115,7 +115,7 @@ func TestSecretScanningService_ListAlertsForOrg(t *testing.T) {
date := Timestamp{time.Date(1996, time.June, 20, 00, 00, 00, 0, time.UTC)}
want := []*SecretScanningAlert{
{
Number: Int64(1),
Number: Int(1),
CreatedAt: &date,
URL: String("https://api.github.com/repos/o/r/secret-scanning/alerts/1"),
HTMLURL: String("https://github.com/o/r/security/secret-scanning/1"),
Expand Down Expand Up @@ -180,7 +180,7 @@ func TestSecretScanningService_ListAlertsForRepo(t *testing.T) {
date := Timestamp{time.Date(1996, time.June, 20, 00, 00, 00, 0, time.UTC)}
want := []*SecretScanningAlert{
{
Number: Int64(1),
Number: Int(1),
CreatedAt: &date,
URL: String("https://api.github.com/repos/o/r/secret-scanning/alerts/1"),
HTMLURL: String("https://github.com/o/r/security/secret-scanning/1"),
Expand Down Expand Up @@ -242,7 +242,7 @@ func TestSecretScanningService_GetAlert(t *testing.T) {

date := Timestamp{time.Date(1996, time.June, 20, 00, 00, 00, 0, time.UTC)}
want := &SecretScanningAlert{
Number: Int64(1),
Number: Int(1),
CreatedAt: &date,
URL: String("https://api.github.com/repos/o/r/secret-scanning/alerts/1"),
HTMLURL: String("https://github.com/o/r/security/secret-scanning/1"),
Expand Down Expand Up @@ -282,7 +282,7 @@ func TestSecretScanningService_UpdateAlert(t *testing.T) {
v := new(SecretScanningAlertUpdateOptions)
json.NewDecoder(r.Body).Decode(v)

want := &SecretScanningAlertUpdateOptions{State: "resolved", Resolution: "used_in_tests"}
want := &SecretScanningAlertUpdateOptions{State: String("resolved"), Resolution: String("used_in_tests")}

if !cmp.Equal(v, want) {
t.Errorf("Request body = %+v, want %+v", v, want)
Expand All @@ -304,7 +304,7 @@ func TestSecretScanningService_UpdateAlert(t *testing.T) {
})

ctx := context.Background()
opts := &SecretScanningAlertUpdateOptions{State: "resolved", Resolution: "used_in_tests"}
opts := &SecretScanningAlertUpdateOptions{State: String("resolved"), Resolution: String("used_in_tests")}

alert, _, err := client.SecretScanning.UpdateAlert(ctx, "o", "r", 1, opts)
if err != nil {
Expand All @@ -313,7 +313,7 @@ func TestSecretScanningService_UpdateAlert(t *testing.T) {

date := Timestamp{time.Date(1996, time.June, 20, 00, 00, 00, 0, time.UTC)}
want := &SecretScanningAlert{
Number: Int64(1),
Number: Int(1),
CreatedAt: &date,
URL: String("https://api.github.com/repos/o/r/secret-scanning/alerts/1"),
HTMLURL: String("https://github.com/o/r/security/secret-scanning/1"),
Expand Down Expand Up @@ -380,10 +380,10 @@ func TestSecretScanningService_ListLocationsForAlert(t *testing.T) {
Type: String("commit"),
Details: &SecretScanningAlertLocationDetails{
Path: String("/example/secrets.txt"),
Startline: Int64(1),
EndLine: Int64(1),
StartColumn: Int64(1),
EndColumn: Int64(64),
Startline: Int(1),
EndLine: Int(1),
StartColumn: Int(1),
EndColumn: Int(64),
BlobSHA: String("af5626b4a114abcb82d63db7c8082c3c4756e51b"),
BlobURL: String("https://api.github.com/repos/o/r/git/blobs/af5626b4a114abcb82d63db7c8082c3c4756e51b"),
CommitSHA: String("f14d7debf9775f957cf4f1e8176da0786431f72b"),
Expand Down