Skip to content

Conversation

@bhogatemadhura
Copy link
Contributor

@bhogatemadhura bhogatemadhura commented Sep 22, 2021

Fixes: #2098.

@google-cla
Copy link

google-cla bot commented Sep 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 22, 2021
@bhogatemadhura
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Sep 22, 2021
@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #2102 (6883a89) into master (dfcb780) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2102   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files         109      109           
  Lines        9724     9726    +2     
=======================================
+ Hits         9508     9510    +2     
  Misses        150      150           
  Partials       66       66           
Impacted Files Coverage Δ
github/event_types.go 100.00% <ø> (ø)
github/messages.go 100.00% <ø> (ø)
github/repos.go 98.64% <ø> (ø)
github/event.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcb780...6883a89. Read the comment docs.

@gmlewis gmlewis changed the title feat: added BranchProtectionRuleEvent Add BranchProtectionRuleEvent Sep 22, 2021
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bhogatemadhura .
Please address the following issues.

bhogatemadhura and others added 19 commits September 22, 2021 09:31
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Co-authored-by: Glenn Lewis <[email protected]>
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bhogatemadhura !
One minor tweak, please, then LGTM.

After the tweak, awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp September 22, 2021 17:25
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bhogatemadhura !
LGTM.

Awaiting second LGTM before merging.

@bhogatemadhura
Copy link
Contributor Author

bhogatemadhura commented Sep 23, 2021

@wesleimp : can I get your consent too ? :-)

@bhogatemadhura
Copy link
Contributor Author

@gmlewis : How long do we wait to get the second approval ?

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2021

@gmlewis : How long do we wait to get the second approval ?

However long it takes, since this repo is maintained by volunteers. 😁

However, if there is an urgent need, I've found that @Parker77 has been incredibly responsive and may be able to help.

@bhogatemadhura
Copy link
Contributor Author

Thank you @gmlewis.Unforutnately, I need this fix soon. Hoping @Parker77 helps out :)

Copy link

@Parker77 Parker77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2021

LGTM!

Thank you, @Parker77 !
Merging.

@gmlewis gmlewis merged commit 55021d5 into google:master Sep 23, 2021
@gmlewis
Copy link
Collaborator

gmlewis commented Sep 23, 2021

@bhogatemadhura - https://github.com/google/go-github/releases/tag/v39.1.0 now contains this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

branch_protection_rule event type not available

3 participants