Skip to content

Add Slug field to AppConfig in manifest workflow #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 1 commit into from
Aug 4, 2021
Merged

Add Slug field to AppConfig in manifest workflow #2029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add Slug field to AppConfig
  • Loading branch information
@rpelliard
rpelliard committed Aug 4, 2021
commit d84383fadeb011f3488bf6f1f6390686e0f696ec
1 change: 1 addition & 0 deletions github/apps_manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
// AppConfig describes the configuration of a GitHub App.
type AppConfig struct {
ID *int64 `json:"id,omitempty"`
Slug *string `json:"slug,omitempty"`
NodeID *string `json:"node_id,omitempty"`
Owner *User `json:"owner,omitempty"`
Name *string `json:"name,omitempty"`
Expand Down
2 changes: 2 additions & 0 deletions github/apps_manifest_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ func TestAppConfig_Marshal(t *testing.T) {

u := &AppConfig{
ID: Int64(1),
Slug: String("s"),
NodeID: String("nid"),
Owner: &User{
Login: String("l"),
Expand Down Expand Up @@ -107,6 +108,7 @@ func TestAppConfig_Marshal(t *testing.T) {

want := `{
"id": 1,
"slug": "s",
"node_id": "nid",
"owner": {
"login": "l",
Expand Down
8 changes: 8 additions & 0 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.