Skip to content

Add missing CreatedAt and UpdatedAt fields to CheckSuite #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gmlewis merged 1 commit into from
Jul 12, 2021
Merged

Add missing CreatedAt and UpdatedAt fields to CheckSuite #1983

gmlewis merged 1 commit into from
Jul 12, 2021

Conversation

@recurser
Copy link
Contributor

@recurser recurser commented Jul 12, 2021

This adds the created_at and updated_at fields to CheckSuite. See REST API docs.

@google-cla google-cla bot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1983 (acf64ed) into master (f47f8fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files         105      105           
  Lines        6809     6809           
=======================================
  Hits         6662     6662           
  Misses         80       80           
  Partials       67       67
Impacted Files Coverage Δ
github/checks.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47f8fe...acf64ed. Read the comment docs.

gmlewis
gmlewis approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @recurser !
LGTM.
Merging.

@gmlewis gmlewis merged commit cda3c0f into google:master Jul 12, 2021
@gmlewis gmlewis mentioned this pull request Aug 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlewis gmlewis gmlewis approved these changes

Assignees

No one assigned

Labels

cla: yes Indication that the PR author has signed a Google Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@recurser @gmlewis