Support go1.13 #1279
Merged
Support go1.13 #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 86 86
Lines 6040 6040
=======================================
Hits 4435 4435
Misses 836 836
Partials 769 769Continue to review full report at Codecov.
|
Collaborator
|
You actually don't need to add 1.13 explicitly... the "1.x" version will always test the latest. So what I've been doing is test master plus the latest two version, with "1.x" always capturing the most recent version. So this should really now just be: go:
- "1.x"
- "1.12.x"
- "master"I'd rather not go beyond these three, primarily to keep our build times down. |
Collaborator
Author
|
Thank you, @willnorris! |
theothertomelliott
added a commit
to yext/edward
that referenced
this pull request
Mar 28, 2020
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for go1.13 and bump Travis CI tests from 1.11 to 1.12 and 1.13.