Skip to content

Update apps.go #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 18 commits into from
Aug 24, 2019
Merged

Update apps.go #1238

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b91a2a6
Update apps.go
emoryruscus Jul 23, 2019
d0834e0
Update apps_test.go
emoryruscus Jul 23, 2019
0d94311
Update apps.go - Change 'parameters' to 'options'
emoryruscus Jul 24, 2019
ad7cafc
Update apps_test.go
emoryruscus Jul 24, 2019
243b6b0
Update apps_test.go
emoryruscus Aug 1, 2019
89c7ea2
Update github-accessors.go
emoryruscus Aug 1, 2019
431e8e6
Update github-accessors.go
emoryruscus Aug 1, 2019
bc6f117
Update github-accessors.go
emoryruscus Aug 1, 2019
96f8146
gofmt spacing fix
emoryruscus Aug 5, 2019
d00e1b1
Update apps.go
emoryruscus Aug 5, 2019
040e921
gofmt spacing fix2
emoryruscus Aug 5, 2019
24ee2e6
Move reader functions for coverage test.
emoryruscus Aug 8, 2019
d069332
Move reader functions for coverage test.
emoryruscus Aug 8, 2019
9a57f54
Update apps.go
emoryruscus Aug 8, 2019
14c5f86
Update apps_test.go
emoryruscus Aug 8, 2019
6289bf9
parent c756c329c19dbbadba0675b42af693093c3f2c45
emoryruscus Jul 23, 2019
5033cff
Merge branch 'patch-1' of https://github.com/emoryruscus/go-github in…
emoryruscus Aug 12, 2019
9d6fd70
Update apps.go
emoryruscus Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move reader functions for coverage test. 
Move GetReadWriter and GetReadCloser from apps.go to apps_test.go to improve coverage.
  • Loading branch information
@emoryruscus
emoryruscus authored Aug 8, 2019
commit d0693320a7664a89fd1291a5a12f2b9eb054bd51
28 changes: 28 additions & 0 deletions github/apps_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,3 +380,31 @@ func TestAppsService_FindUserInstallation(t *testing.T) {
t.Errorf("Apps.FindUserInstallation returned %+v, want %+v", installation, want)
}
}

// GetReadWriter converts a body interface into an io.ReadWriter object.
Copy link
Collaborator

@gmlewis gmlewis Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I much prefer these two new helper functions be used for testing only... thank you!

In fact, since they are rather general purpose, I would be fine to move them to github_test.go if you want, or we could just leave them here for now and move them in a later PR if they become more generally used.

We'll see what @gauntface thinks about them.

Copy link
Contributor Author

@emoryruscus emoryruscus Aug 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! Will leave them here for now if that is alright.

func GetReadWriter(body interface{}) (io.ReadWriter, error) {
var buf io.ReadWriter
if body != nil {
buf = new(bytes.Buffer)
enc := json.NewEncoder(buf)
err := enc.Encode(body)
if err != nil {
return nil, err
}
}
return buf, nil
}

// GetReadCloser converts a body interface into an io.ReadCloser object.
func GetReadCloser(body interface{}) (io.ReadCloser, error) {
buf, err := GetReadWriter(body)
if err != nil {
return nil, err
}

all, err := ioutil.ReadAll(buf)
if err != nil {
return nil, err
}
return ioutil.NopCloser(bytes.NewBuffer(all)), nil
}