Remove xerrors dependency #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For my @tailscale work, we only support the latest Go version. So this SGTM. I'll leave it to @neild to make the call on what's the latest version we want to support here. |
|
Oh wow, you even still test on Go 1.11.x :) I was coming here to suggest that you drop ancient Go versions at this point, so I'm happy to see this PR. It would be nice to drop xerrors as an indirect dependency from a few of my projects. |
neild
approved these changes
Apr 25, 2022
Versions older than Go 1.13 are no longer in use. Remove unnecessary dependencies.
|
I think we can merge this. For some reason GitHub Actions is trying to run on |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions older than Go 1.13 are no longer in use. Remove unnecessary dependencies.