Skip to content

Protect against SQL injection. #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2025
Merged

Protect against SQL injection. #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions googetdb/googetdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,16 +138,17 @@ func (g *GooDB) AddPkg(pkgState client.PackageState) error {
}

// RemovePkg removes a single package from the googet database
func (g *GooDB) RemovePkg(packageName, arch string) error {
removeQuery := fmt.Sprintf(`BEGIN;
DELETE FROM InstalledPackages where pkg_name = '%v' and pkg_arch = '%v';
COMMIT;`, packageName, arch)

_, err := g.db.ExecContext(context.Background(), removeQuery)
func (g *GooDB) RemovePkg(pkgName, arch string) error {
tx, err := g.db.Begin()
if err != nil {
return err
}
return nil
query := `DELETE FROM InstalledPackages where pkg_name = ? and pkg_arch = ?`
if _, err := tx.ExecContext(context.Background(), query, pkgName, arch); err != nil {
tx.Rollback()
return err
}
return tx.Commit()
}

// FetchPkg exports a single package from the googet database
Expand Down Expand Up @@ -186,11 +187,13 @@ func (g *GooDB) FetchPkg(pkgName string) (client.PackageState, error) {
// FetchPkgs exports all of the current packages in the googet database
func (g *GooDB) FetchPkgs(pkgName string) (client.GooGetState, error) {
var state client.GooGetState
pkgQuery := `SELECT pkg_json FROM InstalledPackages ORDER BY pkg_name`
query := `SELECT pkg_json FROM InstalledPackages ORDER BY pkg_name`
var args []any
if pkgName != "" {
pkgQuery = fmt.Sprintf(`SELECT pkg_json FROM InstalledPackages WHERE pkg_name LIKE "%s" ORDER BY pkg_name`, pkgName)
query = `SELECT pkg_json FROM InstalledPackages WHERE pkg_name LIKE ? ORDER BY pkg_name`
args = []any{pkgName}
}
rows, err := g.db.Query(pkgQuery)
rows, err := g.db.Query(query, args...)
if err != nil {
return nil, err
}
Expand Down
Loading