Skip to content

Conversation

@froboy
Copy link
Contributor

@froboy froboy commented Jun 11, 2024

Thanks for all of your hard work!

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @froboy, LGTM. See inline comment for suggested simplification.

Co-authored-by: Patrice Chalin <[email protected]>
@froboy
Copy link
Contributor Author

froboy commented Jul 1, 2024

Pretty sure the failing tests are unrelated to this change...

@chalin
Copy link
Collaborator

chalin commented Jul 1, 2024

The Windows build failure has nothing to do with this PR. Merging.

@chalin chalin merged commit 309da20 into google:main Jul 1, 2024
@chalin chalin added this to the 24Q3 milestone Aug 5, 2024
fekete-robert pushed a commit to fekete-robert/docsy that referenced this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants