Introduce a sync.Pool for ANTLR Lexer / Parser instances #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, the change brings in github.com/antlr/antlr4/pulls/2816 which updates the ANTLR Go runtime. Other applications using vendored code, or alternate sources of truth besides the main ANTLR GitHub repository will also need to be udpated for this change to work.
JimLarson
approved these changes
May 6, 2020
TristonianJones
added a commit
to rachelmyers/cel-go
that referenced
this pull request
Jun 15, 2020
* Introduce a sync.Pool for ANTLR Parser instances * Introduce sync.Pool instances for the Lexer as well. Note, the change brings in github.com/antlr/antlr4/pulls/2816 which updates the ANTLR Go runtime. Other applications using vendored code, or alternate sources of truth besides the main ANTLR GitHub repository will also need to be udpated for this change to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible and safe to re-use ANTLR Parser instances; however, they are not thread safe. Introduce a
sync.Poolfor the CEL ANTLR Parser in order to reduce the construction overhead. This change improves the overall parse / check performance per #346.Note, ANTLR generated lexers cannot be used within a
sync.Pooluntil antlr/antlr4#2816 is merged.