Comprehension nesting limit typo, allow nesting limit validator to accept doubles as limits #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
approved these changes
Jul 17, 2025
renevo
pushed a commit
to Blizzard/cel-go
that referenced
this pull request
Sep 12, 2025
…cept doubles as limits (google#1196) * fix typo * Fix a bug for adapting textproto config to a native config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cel.validator.nesting_comprehension_limit -> cel.validator.comprehension_nesting_limit
Separately, this revealed a bug where we weren't able to instantiate the comprehension nesting limit validator from textproto's config, because its limit value is always a double.