Allow macros to return an empty Expr to indicate a non-expansion #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he implementation level
jnthntatum
reviewed
Nov 4, 2022
jnthntatum
requested changes
Nov 4, 2022
|
PTAL. |
jnthntatum
approved these changes
Nov 4, 2022
TristonianJones
added a commit
to TristonianJones/cel-go
that referenced
this pull request
Nov 8, 2022
…gle#605) * Allow macros to return an empty Expr to indicate a non-expansion at the implementation level * Switch from empty Expr to nil expr to indicate non-expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow macro implementations to indicate a non-expansion by returning an empty
Exprvalue.In the cel-cpp project an empty
Exprreturn value indicates a non-match, so this change ensuresthat the capabilities of cel-go and cel-cpp are at parity.