Skip to content

Conversation

@sahil-madeka
Copy link
Contributor

Pull Requests Guidelines

See CONTRIBUTING.md for more details about when to create
a GitHub Pull Request and when other kinds of contributions or
consultation might be more desirable.

When creating a new pull request, please fork the repo and work within a
development branch.

Commit Messages

  • Most changes should be accompanied by tests.
  • Commit messages should explain why the changes were made.
Summary of change in 50 characters or less

Background on why the change is being made with additional detail on
consequences of the changes elsewhere in the code or to the general
functionality of the library. Multiple paragraphs may be used, but
please keep lines to 72 characters or less.

Reviews

  • Perform a self-review.
  • Make sure the Travis CI build passes.
  • Assign a reviewer once both the above have been completed.

Merging

  • If a CEL maintaner approves the change, it may be merged by the author if
    they have write access. Otherwise, the change will be merged by a maintainer.
  • Multiple commits should be squashed before merging.
  • Please append the line closes #<issue-num>: description in the merge message,
    if applicable.

sahil-madeka and others added 4 commits February 9, 2022 13:20
This allows users of the go CEL library to consume this code. This
change also adds a round tripping test case for the converters

Move ref.value <-> api.expr.Value converters to io.go

Initial commit to test compilation

Fix compilation issues caused by previous commit

Add round tripping test for ref.Val <-> Value converter

Fix compilation issues and ensure that io_test runs and works
@sahil-madeka sahil-madeka changed the title Move ref.Val -> api.expr.Value converter to provider.go Move ref.Val -> api.expr.Value converter to io.go Feb 10, 2022
@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones
Copy link
Collaborator

/gcbrun

@TristonianJones TristonianJones merged commit 5f34cb6 into google:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants