Skip to content

Fix the panic in the codelab solution #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix the panic in the codelab solution #479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions codelab/solution/codelab.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,10 @@ func exercise6() {

// Construct an environment and indicate that the container for all references
// within the expression is `google.rpc.context.AttributeContext`.
requestType := &rpcpb.AttributeContext_Request{}
env, _ := cel.NewEnv(
cel.Container("google.rpc.context.AttributeContext"),
cel.Types(&rpcpb.AttributeContext_Request{}),
cel.Types(requestType),
cel.Declarations(
decls.NewVar("jwt", decls.NewMapType(decls.String, decls.Dyn)),
decls.NewVar("now", decls.Timestamp),
Expand All @@ -289,9 +290,7 @@ func exercise6() {
decls.NewObjectType("google.rpc.context.AttributeContext.Request"))
program, _ := env.Program(ast)

// Construct the message. The result is a ref.Val whose Value() method will
// return the underlying proto message. No conversion from CEL type to native
// type required.
// Construct the message. The result is a ref.Val that returns a dynamic proto message.
out, _, _ := eval(
program,
map[string]interface{}{
Expand All @@ -306,11 +305,13 @@ func exercise6() {
"now": &tpb.Timestamp{Seconds: time.Now().Unix()},
},
)
// Unwrap the CEL value to a proto. No type conversion necessary here, though
// the ConvertToNative function would yield the same value as out.Value() in
// this case.
req := out.Value().(*rpcpb.AttributeContext_Request)
bytes, err := prototext.Marshal(req)
// Unwrap the CEL value to a proto. Make sure to use the `ConvertToNative` to convert
// the dynamic proto message to the concrete type expected.
req, err := out.ConvertToNative(reflect.TypeOf(requestType))
if err != nil {
glog.Exit(err)
}
bytes, err := prototext.Marshal(req.(proto.Message))
if err != nil {
glog.Exitf("failed to marshal proto to text: %v", req)
}
Expand Down