Populate macro calls #455
Merged
Populate macro calls #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all macro replacements will be stored in sourceInfo.MacroCalls
…sted macros, macros as targets, and nested macro args should all be stored as a simple ID for lookup in the macro calls table.
Collaborator
|
/gcbrun |
…ppending. Simplify creating expressions and use accessor functions instead of accessing fields directly.
Collaborator
|
/gcbrun |
TristonianJones
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate the macroCalls map in sourceInfo with macro expressions while parsing. For macro expressions nested in other macros, the map stores the argument ID of the nested macro for self reference instead of the full expression.
Storing the ID instead of the full argument reduces expression duplication in macroCalls and reduces overall size.
While iterating the AST, expression IDs can be looked up in macroCalls and continue from there. Nested macros can also be looked up by ID while iterating a macro in macroCalls.
This change covers cases where a macro is the target so some other macro such as
has(a.b).filter(x, x > 0), and cases where macros are nested inside the arguments of subexpressions likex.filter(y, y.exists(z, has(z.a)) && y.exists(z, has(z.b)))Fixes issue #292