Ensure protodesc.FileDescriptor references are sourced from the global proto registry #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimLarson
approved these changes
Jan 29, 2021
| // Note: Proto reflection relies on descriptor values being object equal rather than object | ||
| // equivalence. This choice means that a FieldDescriptor generated from a FileDescriptorProto | ||
| // will be incompatible with the FieldDescriptor in the global registry and any message created | ||
| // from that global registry. |
Contributor
There was a problem hiding this comment.
Document somewhere the internal constraint that the cel library must not register anything in protoregistry.GlobalFiles as doing so might violate the isolation needed by ExprService.
…l proto registry when possible
9a6e416 to
79c3eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round-tripping from a
protoreflect.FileDescriptorto aFileDescriptorProtoand back results in aprotoreflect.FileDescriptorvalue which is incompatible with the original. This is by design. Based on this choice, allprotoreflect.FileDescriptorvalues must be checked to see if they are also defined in theprotoregistry.GlobalFilesand if so, sourced from the global proto registry rather than taken as-is.