Add tests for reporters #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build benchmark 491 failed (commit 30aec0605c by @mkurdej) |
|
✅ Build benchmark 492 completed (commit d7b1f60e74 by @mkurdej) |
dmah42
approved these changes
Oct 27, 2016
include/benchmark/benchmark_api.h
Outdated
|
|
||
| public: | ||
| // FIXME: Make this private somehow. | ||
| private: |
There was a problem hiding this comment.
wonderful! can you move it down with the other privates please?
There was a problem hiding this comment.
Did you mean removing the duplicated private:? Cf. the last commit.
|
✅ Build benchmark 493 completed (commit ee73d36897 by @mkurdej) |
|
Thanks! |
EricWF
pushed a commit
to efcs/benchmark
that referenced
this pull request
Dec 24, 2016
* Test bytes_per_second and items_per_second. * Test SetLabel. * Reformat. * Make State::error_occurred_ private. * Fix tests with floats. * Merge private blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.