Skip to content

Conversation

@EfesX
Copy link
Contributor

@EfesX EfesX commented Feb 26, 2025

Fixes #1939

@LebedevRI
Copy link
Collaborator

Yep, something like this should work i suppose.

...for msvc
@LebedevRI
Copy link
Collaborator

Hm, and the msvc failures seem real, probably need to explicitly cast something in tests from size_t to int64_t.

@LebedevRI
Copy link
Collaborator

Looks like more casts are needed :)

add the correct explicitly casts
@LebedevRI
Copy link
Collaborator

Hmm, those msvc failure look weird. I don't think this PR can cause them.

@EfesX
Copy link
Contributor Author

EfesX commented Feb 28, 2025

Hmm, those msvc failure look weird. I don't think this PR can cause them.

I reproduced the failure on my Windows computer. I don’t understand why, but it seems like the failure is caused by my PR.

e1eaa52 may help.

@dmah42 dmah42 merged commit 5a4c459 into google:main Mar 12, 2025
84 of 86 checks passed
@LebedevRI
Copy link
Collaborator

@EfesX thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Invalid Pointer Dereference due to std::vector auto-resizing in Memory Manager Result push_back

3 participants