[clang-tidy] autofix cppcoreguidelines #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LebedevRI
reviewed
Feb 12, 2025
include/benchmark/benchmark.h
Outdated
| SystemInfo const& sys_info; | ||
| // The number of chars in the longest benchmark name. | ||
| size_t name_field_width; | ||
| size_t name_field_width{}; |
Collaborator
There was a problem hiding this comment.
This should probably be =0;
Member
Author
There was a problem hiding this comment.
it would be nice if clang-tidy followed published guidelines (https://abseil.io/tips/88 and https://abseil.io/tips/146). i'll redo the automation here.
Collaborator
There was a problem hiding this comment.
There is probably a configuration knob for that, i'd guess. Or maybe not.
Member
Author
There was a problem hiding this comment.
so it should now be using the config in .clang-format (which it wasn't before, so it should be a bit more consistent. hopefully.
LebedevRI
previously approved these changes
Feb 12, 2025
Collaborator
LebedevRI
left a comment
There was a problem hiding this comment.
Generally really not a fan of zero-init (since it hides genuine issues),
but seems harmless in these cases.
LebedevRI
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1925