[clang-tidy] use unique_ptr for benchmark registration #1927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LebedevRI
reviewed
Feb 11, 2025
LebedevRI
approved these changes
Feb 11, 2025
dmah42
added a commit
that referenced
this pull request
Feb 11, 2025
* use unique_ptr for benchmark registration
dmah42
added a commit
that referenced
this pull request
Feb 11, 2025
* [clang-tidy] fix warning about decaying array to pointer * fix a different warning (old style cast) * use string_view instead of old-style const char* strings * ensure bazel windows is using c++17 * learn to use bazel * and tests * precommit fix * more string_view creation and casting * format * format * [clang-tidy] use unique_ptr for benchmark registration (#1927) * use unique_ptr for benchmark registration
r-devulap
added a commit
to r-devulap/x86-simd-sort
that referenced
this pull request
Sep 10, 2025
Adapting to new google benchmark requirements of >= v1.9.2. See google/benchmark#1927
r-devulap
added a commit
to r-devulap/x86-simd-sort
that referenced
this pull request
Sep 10, 2025
Adapting to new google benchmark requirements of >= v1.9.2. See google/benchmark#1927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1925