Change SDK version check #1887
Merged
Change SDK version check #1887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that github seems to have updated its builders, perhaps we can check the SDK version the more standard way.
dmah42
approved these changes
Dec 10, 2024
Member
|
fab. thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1859. When that was merged, github's windows builders were only partially updated to the new windows build tools (see this issue for more information). We worked around this by checking the installed SDK version in a funky way, which seems to have stopped working (#1886) now that they've fully updated.
If we ever decide that the new SDK is a requirement to build, we can remove the check entirely and just include the code unconditionally.