[#1487] ensure background color is preserved #1865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
Contributor
Author
|
|
Contributor
Author
|
|
Member
|
clang-format fixes needed but also #1867 probably needed. |
ea30cad to
b93d585
Compare
Contributor
Author
|
Sorry, I need to get myself setup locally with clang-tidy so I don't put pressure on these actions prematurely |
Member
i do have it set up locally and i still get it wrong. it's fine, it's what the actions are there for. |
b93d585 to
7fe76d7
Compare
dmah42
previously approved these changes
Oct 23, 2024
a3cace4 to
8d673da
Compare
dmah42
previously approved these changes
Oct 23, 2024
Member
i'm struggling to see the difference... is it one more space on the second one? |
Contributor
Author
|
Yes, I'm struggling to get clang-format-lint to be happy. |
Member
|
took a closer look. on that line above there's an extra space after the | |
…or of the terminal on windows is preserved
06239b0 to
9fde32c
Compare
dmah42
approved these changes
Oct 24, 2024
Member
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in issue 1487, the color of the background on Windows was assumed to be black. This means that when printing results in, for example, green, you ended up with green on black regardless of the original background color.
This update retains the background colors when printing.
This naturally raises another topic of, does the output color want to be determined by the background color when printing? I.e we would now end up printing green text on a green background if that were the case. Maybe this can be captured in another request if it's desirable.