add PERF_FORMAT_TOTAL_TIME_{ENABLED,RUNNING} to support multiplexing #1814
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice, thanks for adding :) I think this does not fully fix the issue. Adding the flags changes the in-memory layout of the counters. It remains to add those to the struct, replacing the 'padding' field, and then to extrapolate the counters based on the fraction of enabled/running. |
Member
Author
|
do you have a pointer? i have no idea how this is meant to work. |
Member
|
Check out cl/638153709 :) |
Member
Author
|
i think it's quite a different approach to how we currently do things, and i'm not qualified to rewrite this so we may need to find someone who knows what they're doing. |
Member
|
SG. In the meantime, probably best to revert this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1813