Fix warning with MacOS #1276
Merged
Fix warning with MacOS #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bensuperpc <[email protected]>
Signed-off-by: Bensuperpc <[email protected]>
|
nit: is this line > 80 characters? can you run |
Signed-off-by: Bensuperpc <[email protected]>
|
Please don't just reformat the whole file, only the new change. |
This reverts commit 1d5fe9c.
Signed-off-by: Bensuperpc <[email protected]>
|
It is now fixed ^^ |
|
thanks! |
sergiud
pushed a commit
to sergiud/benchmark
that referenced
this pull request
Jan 13, 2022
* Fix warning with MacOS Signed-off-by: Bensuperpc <[email protected]> * Re-trigger GitHub actions Signed-off-by: Bensuperpc <[email protected]> * Fix style Signed-off-by: Bensuperpc <[email protected]> * Revert "Fix style" This reverts commit 1d5fe9c. * Fix style only on changes Signed-off-by: Bensuperpc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reinterpret_cast instead old style cast on MacOS, to fix warning with -Wold-style-cast, more C++ compliant.
It triggers an error when we compiled with gtest.