Add wheel and sdist building action to GH Workflow #1180
Conversation
|
i have no idea if this looks good or not :| i mean it looks like it will probably work? :) i'd love someone who knows what they're talking about to help review... |
There was a problem hiding this comment.
Not an expert but LTGM.
@vincenzopalazzo review this PR e991355
|
good enough for me! |
| env: | ||
| CIBW_BUILD: 'cp36-* cp37-* cp38-* cp39-*' | ||
| run: | | ||
| pip install cibuildwheelcibuildwheel==2.0.0a2 |
There was a problem hiding this comment.
Looks like a typo?
Should it be pip install cibuildwheel? Also why pin the version to an alpha version?
There was a problem hiding this comment.
Hi @yashk2810! That's most definitely a typo. If I remember correctly, I wanted to substitute cibuildwheel for an unpinned version. The alpha there was used in a cibuildwheel user guide that I read, this should have been right around the time they bumped from 1.x to 2.0, though a little bit before, which is why no 2.0.x wheels existed yet.
But in any case, this needs more work. I took my eye off of this to focus on a personal project, which was supposed to use prebuilt google-benchmark wheels, but I think I can revisit this soon.
Working to fix #1177. I added a workflow for building wheels and an sdist and uploading it to GitHub. I set the proposed wheel building workflow to manual dispatch as of now, so it can be checked whether or not it works.
For later, it could be worth adding a publishing job running after release/tagging/manually, but I don't know how you guys handle this for Python (it would require a PyPI token secret added to this repo for instance), so I left it out for now. Would be excited about some feedback.