Fix formatting issues introduced by a77d5f7 #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we're mostly clang-format tidy with the google style. if you can see if this matches the output of that, it'd be great. |
Yup, this patch reduces the changes requested by |
|
LGTM modulo CI |
dmah42
approved these changes
Apr 17, 2020
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
"=r" (tb)is a clear formatting oversight. The other white space issues are more a matter of style, but seem reasonable and consistent with the rest of the project. Incorporating these changes upstream would minimize lint issues when cherry-picking into LLVM the changes introduced by a77d5f7.