Skip to content

Conversation

Gluttton
Copy link

@Gluttton Gluttton commented Feb 1, 2014

No description provided.

@Gluttton
Copy link
Author

Gluttton commented Feb 3, 2014

In any case, in future it can be source of new questions and problems (like issue #5 and issue #6). In my opinion extract examples into separate source file better rather than fix comments time to time.

@dmah42
Copy link
Member

dmah42 commented Feb 3, 2014

Thank you - I agree that having the examples in source is important (and they are, in fact: https://github.com/google/benchmark/blob/master/test/benchmark_test.cc) but having the examples in the comment in the main header makes it easier for users to find.

It's a difficult balance.

dmah42 pushed a commit that referenced this pull request Feb 3, 2014
Some errors in usage examples were fixed.
@dmah42 dmah42 merged commit c40b85e into google:master Feb 3, 2014
@Gluttton Gluttton deleted the fix_errors_in_examples branch February 3, 2014 19:36
@pphaneuf
Copy link
Contributor

pphaneuf commented Feb 4, 2014

Sorry, we had to revert this merge, because it appears @Gluttton has not signed the CLA (contributor license agreement)? I'm a bit new to this here, so I might be wrong, but you'd be looking at one of the following two, as appropriate:

https://developers.google.com/open-source/cla/individual
https://developers.google.com/open-source/cla/corporate

@pphaneuf
Copy link
Contributor

pphaneuf commented Feb 4, 2014

To be clear, let us know as soon as you signed it, we'll check it's good on our side and re-integrate your commit. This is just a minor administrative setback, sorry about that.

@pphaneuf
Copy link
Contributor

pphaneuf commented Feb 4, 2014

And you only need to sign one, whichever is more appropriate for your situation.

@Gluttton
Copy link
Author

Gluttton commented Feb 4, 2014

English isn't my mother tongue, so I don't clearly understand meaning of the licence. As result, I wouldn't like to sign it (and any other document meaning of which I don't understand). But it doesn't mean that I have any claims!

In any way my changes couldn't be called as something significant and revert looks like the most simple way. I'm realy sorry that I've made your trouble. I admire the Google and your projects!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants