spvc memory leak and error code handling fixes #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuetschard
approved these changes
May 12, 2022
gapis/shadertools/shadertools.go
Outdated
|
|
||
| default: | ||
| return "", sourceLanguage, false, errors.New("Source language not supported") | ||
| retError = errors.New("Source language \"" + sourceLanguage + "\" is not supported: ") |
There was a problem hiding this comment.
is there supposed to be something after the :?
There was a problem hiding this comment.
Good catch Pascal! I was initially going to add sourceLanguage to the end. Will fix that and merge.
Thanks
yalcinmelihyasin
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a memory leak with the shader compilation requests made on the server, which can lead to high memory consumption due to redundant requests when the compilations are failed.
Also changed the return value check on spvc_context_create_compiler to cover other error codes.