test: refactor npm artifact checks #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Aug 17, 2025
- Tests pass
- Appropriate changes to README are included in PR
483e942 to
bd5a25e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the npm artifact tests by consolidating package-related tests from package.test.js into the existing build-npm.test.js file, improving test organization and eliminating duplication.
- Moved npm package content verification tests from
package.test.jstobuild-npm.test.js - Added compatibility tests for JavaScript and TypeScript project scenarios
- Updated package version from 8.8.0 to 8.8.1 across multiple files
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/package.test.js | Completely removed - all tests moved to build-npm.test.js |
| test/it/build-npm.test.js | Added comprehensive npm artifact tests including content verification and compatibility checks |
| test/all.test.js | Removed import of deleted package.test.js |
| src/versions.ts | Updated zx version to 8.8.1 |
| package.json | Updated package version to 8.8.1 |
| build/index.cjs | Updated compiled version string to 8.8.1 |
| .github/workflows/publish.yml | Added node_modules/depseek to artifact uploads |
| .github/workflows/dev-publish.yml | Added node_modules/depseek to artifacts and reordered version setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.