feat: expose internal deps versions #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: export zx own version as static value fixes google#1295
There was a problem hiding this comment.
Pull Request Overview
This PR exposes internal dependency versions through a new versions object in the zx library. It replaces the dynamic version reading with a static approach and provides users access to versions of all internal dependencies.
Key changes:
- Added a static
versionsobject that exports versions of zx and its dependencies - Replaced dynamic VERSION reading with a static reference to versions.zx
- Created a build script to generate the versions file automatically
Reviewed Changes
Copilot reviewed 14 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/versions.ts | New file defining the static versions object with zx and dependency versions |
| src/index.ts | Updated VERSION constant to use static versions.zx instead of dynamic file reading |
| src/goods.ts | Added export of versions from versions.ts |
| scripts/build-versions.mjs | New build script to automatically generate versions.ts from package.json files |
| package.json | Updated build process to include versions generation step |
| test/* | Added comprehensive test coverage for the new versions functionality |
| docs/api.md | Added documentation for the new versions API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1295