refactor: minor promisifyStream tweak up
#1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Jul 20, 2025
- Tests pass
- Appropriate changes to README are included in PR
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the promisifyStream function to improve code organization and reduce duplication. The changes introduce a symbol constant for the 'end-piped-from' event and consolidate duplicate event handler logic.
- Introduces a new symbol constant
EPFto replace the magic string 'end-piped-from' - Consolidates duplicate event handler logic in
promisifyStreamby extracting a sharedonendfunction - Updates size limits to reflect the reduced bundle size from the refactoring
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/core.ts | Adds EPF symbol constant and refactors promisifyStream to reduce code duplication |
| build/core.cjs | Compiled version of the TypeScript changes with the same refactoring |
| .size-limit.json | Updates bundle size limits to reflect the smaller output from code optimization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.