-
Notifications
You must be signed in to change notification settings - Fork 44
Make linefeed OS-agnostic in unit tests #118
Conversation
Ensure no tests fail due to \n differs to \r\n on Windows, while maintaining Linux/MacOS compatibility
Left out of previous commit
Template file is stored with \n and will not be affected by operating system
|
Appveyor result: https://ci.appveyor.com/project/Nilzor/composer/build/appveyor%204#L454 Down to 6 errors - all related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long review.
|
@Nilzor regarding 6 issues with the |
|
Do we really need to be able to run the tests on Windows though? Having the production code running on Windows and having the development environment run are two different things. Running docker on Windows is definitely possible, I'm just not sure it's worth investing in it. There are a couple of approaches we could take:
I'm leaning towards number 3, or not doing anything at all with regards to testing on Windows |
|
PS: Thanks for the merge - could you also please make a new release build? |
|
Well, running all tests on Windows would make us sure that all stuff continues working on Windows after new changes. |
|
Pushed new release, too. |
Ensure no tests fail due to \n differs to \r\n on Windows,
while maintaining Linux/MacOS compatibility
edit: Might hold off the merge until I've verified that tests in
HtmlReportSpecpasses. I'm struggling to generateapp.min.js(or you can verify it on AppVeyor)edit 2:
HtmlReportSpechave other issues not related to Linefeed or Windows. I believe this PR can be merged