garray代码规范化 #1361
garray代码规范化 #1361
Conversation
| } | ||
|
|
||
| // See New. | ||
| // NewArray See New. |
There was a problem hiding this comment.
在goland新的规范中，要把函数名写在注释之前，下图是没有写上函数名的提示：
There was a problem hiding this comment.
我的意思是NewArray See New.这句注释不通顺，需要给定完整的方法说明，或者友好地提示开发者去哪里查看使用说明。
There was a problem hiding this comment.
@jroam 比如注释改为NewArray is alias of New, please see New. 都比NewArray See New要好，我是这个意思。
| } | ||
|
|
||
| // See PushRight. | ||
| // Append See PushRight. |
| return false | ||
| } | ||
| return true | ||
| return a.array[i] > a.array[j] |
| } | ||
|
|
||
| // See PushRight. | ||
| // Append See PushRight. |
| } | ||
|
|
||
| // See New. | ||
| // NewArray See New. |
There was a problem hiding this comment.
我的意思是NewArray See New.这句注释不通顺，需要给定完整的方法说明，或者友好地提示开发者去哪里查看使用说明。
|
在gf中，很多的注释都是这样写的，所以应该保持一样的风格： |
| } | ||
|
|
||
| // See New. | ||
| // NewArray See New. |
There was a problem hiding this comment.
@jroam 比如注释改为NewArray is alias of New, please see New. 都比NewArray See New要好，我是这个意思。
Codecov Report
@@ Coverage Diff @@
## develop #1361 +/- ##
===========================================
- Coverage 70.78% 70.66% -0.12%
===========================================
Files 372 376 +4
Lines 32046 32228 +182
===========================================
+ Hits 22683 22774 +91
- Misses 7770 7840 +70
- Partials 1593 1614 +21
Continue to review full report at Codecov.
|
No description provided.