-
Notifications
You must be signed in to change notification settings - Fork 810
Update to protobuf 3.5.1 and minor cleanups for Golang 1.10 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Only new protobuf versions that are available for download with wget are supported. Maybe choose a less minor version? |
Whoops, fixed |
Seems |
Updated to only run on Golang 1.9 |
Ah damn I forgot we don't have the go version in the matrix vars. So now the CHECK_DIFF var does not make sense anymore I suggest this and removing CHECK_DIFF entirely
Also please keep And then we need to add go 1.10 to the go versions being tested, since otherwise we are not checking the diff. Then we also need to add these new versions that we are testing to the Readme.md |
I think this is ready to go. |
.travis.yml
Outdated
- PATH=/home/travis/bin:$PATH make buildserverall | ||
- echo $TRAVIS_GO_VERSION | ||
- if [ "$CHECK_DIFF" == 1 ]; then ! git status --porcelain | read || (git status; git diff; exit 1); fi | ||
- if [[ "$PROTOBUF_VERSION" == "3.5.0" ]] && [[ "$TRAVIS_GO_VERSION" =~ ^1\.9\.[0-9]+$ ]]; then ! git status --porcelain | read || (git status; git diff; exit 1); fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.5.1 ?
That regex and the fact that I can't see git diff actually running is freaking me out :( |
What do you want to do? |
Ah I see the go: 1.9.x has ruled out the possibility of simply doing an equal. Hmmm |
I have checked previous versions that check diff and the print out is the same. And now that I am back from holiday your regex looks really simple. |
@peter-edge Thank you for putting up with these really drawn out comments. |
This does the following:
go vet
to work in Golang 1.10