Honor casttype on maps #119
Conversation
49f9722 to
b6fc28e
Compare
|
Getter generation is still broken here. |
|
Aha so instead of castkey and castvalue rather casttype the whole maptype. That works for me. |
There was a problem hiding this comment.
I would prefer not factoring it out into a function, since I have to merge in future changes from golang/protobuf. For that reason I try to keep the diff as small as possible.
generator.go is typically the hardest to maintain, since the diff is already so large, but every little bit helps.
There was a problem hiding this comment.
Hrm - I'm about to push the castkey and castvalue change which builds on that - it was harder there to get the appropriate info (need a fair amount of calculation for maps) and so I have an even larger method. Can you comment on an alternative structure there so I can get an idea what is easier to maintain for you?
There was a problem hiding this comment.
Please see #120 and smarterclayton@e47b2f8#diff-c5ab46099bd055be2629de524005c350R1762 and let me know what is going to be easier to maintain. Should I create a new file that offers this type and leave the old factoring?
There was a problem hiding this comment.
I answered this in the other pull request
|
exciting :) |
|
I think everything is in the other pull request, so I am going to close this one. |
|
@smarterclayton Would you mind if I add kubernetes to list of gogoprotobuf users? |
|
Please do On Tue, Dec 15, 2015 at 3:56 AM, Walter Schulze [email protected]
|
|
The go2idl generator is almost complete - will write something up on how it On Fri, Jan 8, 2016 at 5:10 PM, Clayton Coleman [email protected] wrote:
|
|
Thank you very much :) Kubernetes added http://gogo.github.io/ I am really excited about go2idl :) |
Respects the casttype extension for maps in Go.
Fixes #116