Skip to content

Conversation

buptbill220
Copy link

Change-Id: Iaab4149b12991e00d2e47e30e7c7a0476ceb82f9

Change-Id: Iaab4149b12991e00d2e47e30e7c7a0476ceb82f9
Change-Id: I813d67cc423c74db2c4d3f7ad3a18b0dbbb78dd2
Copy link
Author

@buptbill220 buptbill220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge to master

fangming added 7 commits May 6, 2019 13:48
Change-Id: I348edfc11f2f18f3856c216facc69a90e3fcd1f1
Change-Id: Ic7965ed198348abc103518e0e125e25d92c464e8
Change-Id: I96d2544df50278829e4f1b9b7bcfe4ba1b3f5bbe
Change-Id: Ie81c47feb77363849c51793422f626acdf20204c
Change-Id: I9c8d0dede71531a34a03b5c8195e653701a3f651
Change-Id: I6806dd9dd3c09f665a4409a36d79dd09bf54e74c
Change-Id: Ieb1dd27b3b99ba0f4eb6cfb319ad605198cc61fd
@jmarais
Copy link
Contributor

jmarais commented May 19, 2019

Hi. It seems like there are a lot of unnecessary changes with your diff.
What feature did you try to add with this pull request?

@buptbill220
Copy link
Author

Hi. It seems like there are a lot of unnecessary changes with your diff.
What feature did you try to add with this pull request?

just suply in some case like this: I have a message, maybe use json or protobuf or anything else protocol. We just describe its protocol with protobuf, but encoding or decoding will be transparent for developer. Developer just tell us its protocol and codec type, then we generate coder file.
exampler:
type Codec interface {
Marshal(msg interface{}) ([]byte, error)
Unmarshal (data []byte, msg interface{}) (error)
}

User.proto
message User {
required int64 id = 1;
required string name = 2
required int32 age = 3;
optional Occupation occ = 4;
repeated Occupation occs = 5;
}
message Occupation {
required int64 id = 1;
required string industry = 2;
}

user := &User{}
user.Unmarshal & user.Marshal, don't case json or protobuf.

fangming added 2 commits July 12, 2019 13:39
Change-Id: Ib5aa2f250b31e745016206f4f256903a0e8c6260
Change-Id: I6a50fb975f4c895da7b6e6d35fd800ccbbc4ed99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants