Fix redirects ignoring AllowURLRevisit=false #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a breaking change: ErrAlreadyVisited is replaced with AlreadyVisitedError, which allows the user to know the redirect destination, which might not match the URL passed to Visit when multiple redirects are followed. See gocolly#405
c7cc4e3 to
0be3b71
Compare
Collaborator
Author
|
No longer draft thanks to #678 being merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a breaking change:
ErrAlreadyVisitedis replacedwith
AlreadyVisitedError, which allows the user to know the redirectdestination, which might not match the URL passed to
Visitwhen multipleredirects are followed.
See #405
Currently draft because it's based on code cleanup made in #678